Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading maps will reveal previously partially revealed tiles #75641

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

HadeanLake
Copy link
Contributor

Summary

Bugfixes "Reading maps will reveal previously partially revealed tiles"

Purpose of change

Steps to reproduce:
-Spawn default character, debug spawn radiotower, binoculars and road map.
-Climb the tower. Use the map.
-See roads revealed in the unexplored area, but not around the tower where character could only make out vague details of what is there.
2024-08-13-113155_1920x1080_scrot

Describe the solution

Using maps will fully reveal tiles that are not fully revealed, instead of revealing tiles that are unexplored.

Testing

Climbed the tower again and used some maps to make sure relevant things revealed both in unexplored area and in partially explored
2024-08-13-124036_1920x1080_scrot

@github-actions github-actions bot added Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` <Bugfix> This is a fix for a bug (or closes open issue) new contributor labels Aug 13, 2024
@HadeanLake HadeanLake marked this pull request as ready for review August 13, 2024 10:03
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 13, 2024
Copy link
Member

@RenechCDDA RenechCDDA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pull the branch but code changes look good. A sensible change.

@akrieger akrieger merged commit 1adf3ef into CleverRaven:master Aug 13, 2024
32 of 39 checks passed
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 13, 2024
@HadeanLake HadeanLake deleted the HadeanLake/Cataclysm-DDA branch August 14, 2024 08:51
@ashGlaw
Copy link
Contributor

ashGlaw commented Aug 14, 2024

Really cool idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants